This repository was archived by the owner on Sep 28, 2022. It is now read-only.
[fix] Correctly aim at the right doc snippet files#94
Merged
Conversation
Aschen
approved these changes
Jun 30, 2020
scottinet
approved these changes
Jun 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Updated a few doc files to aim the real existing .java files, instead of some .js
Current behaviour
How should this be manually tested?
Clone and launch:
npm install & npm run doc-prepare & npm run doc-buildYou should not see any errors related to missing snippets.
Boyscout
To get the ci build to succed, had to update document/update test file to expect:
'expected: "_id=some-id, _version=2"'instead of:
'{expected: "_id=some-id, _version=2"}'